lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <pj41zlmt3wbq4k.fsf@u570694869fb251.ant.amazon.com> Date: Tue, 28 Mar 2023 23:02:11 +0300 From: Shay Agroskin <shayagr@...zon.com> To: Simon Horman <horms@...nel.org> CC: Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, "Arthur Kiyanovski" <akiyano@...zon.com>, David Arinzon <darinzon@...zon.com>, "Noam Dagan" <ndagan@...zon.com>, Saeed Bishara <saeedb@...zon.com>, Tom Rix <trix@...hat.com>, <netdev@...r.kernel.org> Subject: Re: [PATCH net-next] net: ena: removed unused tx_bytes variable Simon Horman <horms@...nel.org> writes: > clang 16.0.0 with W=1 reports: > > drivers/net/ethernet/amazon/ena/ena_netdev.c:1901:6: error: > variable 'tx_bytes' set but not used > [-Werror,-Wunused-but-set-variable] > u32 tx_bytes = 0; > > The variable is not used so remove it. > > Signed-off-by: Simon Horman <horms@...nel.org> > --- > drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c > b/drivers/net/ethernet/amazon/ena/ena_netdev.c > index e0588a82c8e5..e6a6efaeb87c 100644 > --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c > +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c > @@ -1898,7 +1898,6 @@ static int ena_clean_xdp_irq(struct > ena_ring *xdp_ring, u32 budget) > { > u32 total_done = 0; > u16 next_to_clean; > - u32 tx_bytes = 0; > int tx_pkts = 0; > u16 req_id; > int rc; > @@ -1936,7 +1935,6 @@ static int ena_clean_xdp_irq(struct > ena_ring *xdp_ring, u32 budget) > "tx_poll: q %d skb %p completed\n", > xdp_ring->qid, > xdpf); > > - tx_bytes += xdpf->len; > tx_pkts++; > total_done += tx_info->tx_descs; Thanks for submitting this change. Acked-by: Shay Agroskin <shayagr@...zon.com>
Powered by blists - more mailing lists