lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <168003456829.3027256.12371018603759735483.stgit@firesoul> Date: Tue, 28 Mar 2023 22:16:08 +0200 From: Jesper Dangaard Brouer <brouer@...hat.com> To: bpf@...r.kernel.org Cc: Jesper Dangaard Brouer <brouer@...hat.com>, netdev@...r.kernel.org, Stanislav Fomichev <sdf@...gle.com>, martin.lau@...nel.org, ast@...nel.org, daniel@...earbox.net, alexandr.lobakin@...el.com, larysa.zaremba@...el.com, xdp-hints@...-project.net, anthony.l.nguyen@...el.com, yoong.siang.song@...el.com, boon.leong.ong@...el.com, intel-wired-lan@...ts.osuosl.org, pabeni@...hat.com, jesse.brandeburg@...el.com, kuba@...nel.org, edumazet@...gle.com, john.fastabend@...il.com, hawk@...nel.org, davem@...emloft.net Subject: [PATCH bpf RFC 3/4] veth: bpf_xdp_metadata_rx_hash return xdp rss hash type Update API for bpf_xdp_metadata_rx_hash() by returning xdp rss hash type. The veth driver currently only support XDP-hints based on SKB code path. The SKB have lost information about the RSS hash type, by compressing the information down to a single bitfield skb->l4_hash, that only knows if this was a L4 hash value. In preparation for veth, the xdp_rss_hash_type have an L4 indication bit that allow us to return a meaningful L4 indication when working with SKB based packets. Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com> --- drivers/net/veth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index 046461ee42ea..6b1084e39b25 100644 --- a/drivers/net/veth.c +++ b/drivers/net/veth.c @@ -1624,7 +1624,7 @@ static int veth_xdp_rx_hash(const struct xdp_md *ctx, u32 *hash) return -ENODATA; *hash = skb_get_hash(_ctx->skb); - return 0; + return _ctx->skb->l4_hash ? XDP_RSS_TYPE_L4_BIT : XDP_RSS_TYPE_NONE; } static const struct net_device_ops veth_netdev_ops = {
Powered by blists - more mailing lists