netdev - Re: [PATCH net-next v3 1/4] net/sched: act_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b98879d1-f9d1-e552-8fb7-ef2b3e7f8443@mojatatu.com>
Date:   Tue, 28 Mar 2023 18:25:22 -0300
From:   Pedro Tammela <pctammela@...atatu.com>
To:     Davide Caratti <dcaratti@...hat.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Ilya Maximets <i.maximets@....org>
Cc:     Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 1/4] net/sched: act_tunnel_key: add support
 for "don't fragment"

On 28/03/2023 13:45, Davide Caratti wrote:
> extend "act_tunnel_key" to allow specifying TUNNEL_DONT_FRAGMENT.
> 
> Suggested-by: Ilya Maximets <i.maximets@....org>
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>
> ---
>   include/uapi/linux/tc_act/tc_tunnel_key.h | 1 +
>   net/sched/act_tunnel_key.c                | 5 +++++
>   2 files changed, 6 insertions(+)
> 
> diff --git a/include/uapi/linux/tc_act/tc_tunnel_key.h b/include/uapi/linux/tc_act/tc_tunnel_key.h
> index 49ad4033951b..37c6f612f161 100644
> --- a/include/uapi/linux/tc_act/tc_tunnel_key.h
> +++ b/include/uapi/linux/tc_act/tc_tunnel_key.h
> @@ -34,6 +34,7 @@ enum {
>   					 */
>   	TCA_TUNNEL_KEY_ENC_TOS,		/* u8 */
>   	TCA_TUNNEL_KEY_ENC_TTL,		/* u8 */
> +	TCA_TUNNEL_KEY_NO_FRAG,		/* flag */
>   	__TCA_TUNNEL_KEY_MAX,
>   };
>   
> diff --git a/net/sched/act_tunnel_key.c b/net/sched/act_tunnel_key.c
> index 2d12d2626415..0c8aa7e686ea 100644
> --- a/net/sched/act_tunnel_key.c
> +++ b/net/sched/act_tunnel_key.c
> @@ -420,6 +420,9 @@ static int tunnel_key_init(struct net *net, struct nlattr *nla,
>   		    nla_get_u8(tb[TCA_TUNNEL_KEY_NO_CSUM]))
>   			flags &= ~TUNNEL_CSUM;
>   
> +		if (nla_get_flag(tb[TCA_TUNNEL_KEY_NO_FRAG]))
> +			flags |= TUNNEL_DONT_FRAGMENT;
> +
>   		if (tb[TCA_TUNNEL_KEY_ENC_DST_PORT])
>   			dst_port = nla_get_be16(tb[TCA_TUNNEL_KEY_ENC_DST_PORT]);
>   
> @@ -747,6 +750,8 @@ static int tunnel_key_dump(struct sk_buff *skb, struct tc_action *a,
>   				   key->tp_dst)) ||
>   		    nla_put_u8(skb, TCA_TUNNEL_KEY_NO_CSUM,
>   			       !(key->tun_flags & TUNNEL_CSUM)) ||
> +		    ((key->tun_flags & TUNNEL_DONT_FRAGMENT) &&
> +		     nla_put_flag(skb, TCA_TUNNEL_KEY_NO_FRAG)) ||
>   		    tunnel_key_opts_dump(skb, info))
>   			goto nla_put_failure;
>   

LGTM,

Reviewed-by: Pedro Tammela <pctammela@...atatu.com>