netdev - Re: [PATCH v6 net-next 01/14] pds_core: initial framework for pds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230328151700.526ea042@kernel.org>
Date:   Tue, 28 Mar 2023 15:17:00 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Shannon Nelson <shannon.nelson@....com>
Cc:     brett.creeley@....com, davem@...emloft.net, netdev@...r.kernel.org,
        drivers@...sando.io, leon@...nel.org, jiri@...nulli.us
Subject: Re: [PATCH v6 net-next 01/14] pds_core: initial framework for
 pds_core PF driver

On Mon, 27 Mar 2023 23:19:28 -0700 Shannon Nelson wrote:
> > What are you "abstracting away", exactly? Which "later patch"?
> > I'm not going to read the 5k LoC submission to figure out what
> > you're trying to say :(  
> 
> I'm saying that more code is added in later patches around the 
> devlink_register() for the health (patch 4) and parameters (patch 11). 
> This allows me to have a simple line in the main probe logic that does 
> the devlink-register related things, and then have the details collected 
> together off to the side.

It's not supposed to be off to the side, that's my point.
It's a central interface for device control.

> Obviously, when I update the code for using the devl_* interfaces and 
> explicit locking, those two patches will change a little.