netdev - Re: [PATCH net-next 1/4] vlan: Add MACsec offload operations for VLAN interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230328154154.14bbee54@kernel.org>
Date:   Tue, 28 Mar 2023 15:41:54 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Emeel Hakim <ehakim@...dia.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "sd@...asysnail.net" <sd@...asysnail.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/4] vlan: Add MACsec offload operations for
 VLAN interface

On Tue, 28 Mar 2023 06:54:11 +0000 Emeel Hakim wrote:
> > > +     if (real_dev->features & NETIF_F_HW_MACSEC)
> > > +             features |= NETIF_F_HW_MACSEC;
> > > +
> > >       return features;
> > >  }  
> > 
> > Shouldn't vlan_features be consulted somehow?  
> 
> I did consider including the vlan_features, but after careful
> consideration, I couldn't see how they were relevant to the task at
> hand.

Decode this for me please:
 - what was you careful consideration
 - what do you think the task at hand is; and
 - what are vlan_features supposed to mean?