lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <8e87b73a-488b-5070-5043-9f92e9aa9d0e@amd.com> Date: Mon, 27 Mar 2023 22:55:40 -0700 From: Shannon Nelson <shannon.nelson@....com> To: Jason Wang <jasowang@...hat.com> Cc: mst@...hat.com, virtualization@...ts.linux-foundation.org, brett.creeley@....com, davem@...emloft.net, netdev@...r.kernel.org, kuba@...nel.org, drivers@...sando.io Subject: Re: [PATCH v3 virtio 6/8] pds_vdpa: add support for vdpa and vdpamgmt interfaces On 3/27/23 8:53 PM, Jason Wang wrote: > On Sat, Mar 25, 2023 at 8:27 AM Shannon Nelson <shannon.nelson@....com> wrote: >> >> On 3/22/23 10:18 PM, Jason Wang wrote: >>> On Thu, Mar 23, 2023 at 3:11 AM Shannon Nelson <shannon.nelson@....com> wrote: >>>> >>>> This is the vDPA device support, where we advertise that we can >>>> support the virtio queues and deal with the configuration work >>>> through the pds_core's adminq. >>>> >>>> Signed-off-by: Shannon Nelson <shannon.nelson@....com> >>>> --- >>>> drivers/vdpa/pds/aux_drv.c | 15 + >>>> drivers/vdpa/pds/aux_drv.h | 1 + >>>> drivers/vdpa/pds/debugfs.c | 260 +++++++++++++++++ >>>> drivers/vdpa/pds/debugfs.h | 10 + >>>> drivers/vdpa/pds/vdpa_dev.c | 560 +++++++++++++++++++++++++++++++++++- >>>> 5 files changed, 845 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/vdpa/pds/aux_drv.c b/drivers/vdpa/pds/aux_drv.c >>>> index 8f3ae3326885..e54f0371c60e 100644 >>>> --- a/drivers/vdpa/pds/aux_drv.c >>>> +++ b/drivers/vdpa/pds/aux_drv.c >>> >>> [...] >>> >>>> + >>>> +static struct vdpa_notification_area >>>> +pds_vdpa_get_vq_notification(struct vdpa_device *vdpa_dev, u16 qid) >>>> +{ >>>> + struct pds_vdpa_device *pdsv = vdpa_to_pdsv(vdpa_dev); >>>> + struct virtio_pci_modern_device *vd_mdev; >>>> + struct vdpa_notification_area area; >>>> + >>>> + area.addr = pdsv->vqs[qid].notify_pa; >>>> + >>>> + vd_mdev = &pdsv->vdpa_aux->vd_mdev; >>>> + if (!vd_mdev->notify_offset_multiplier) >>>> + area.size = PDS_PAGE_SIZE; >>> >>> This hasn't been defined so far? Others look good. >> >> Sorry, I don't understand your question. >> sln > > I mean I don't see the definition of PDS_PAGE_SIZE so far. > > Thanks Oh, right. That's because it is defined in include/linux/pds/pds_common.h which comes from the pds_core patchset. https://lore.kernel.org/netdev/20230324190243.27722-2-shannon.nelson@amd.com/ sln
Powered by blists - more mailing lists