netdev - Re: [PATCH v2 net-next 2/2] 6lowpan: Remove redundant initialisation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Mar 2023 09:27:43 +0300
From:   Mark Bloch <mbloch@...dia.com>
To:     Kuniyuki Iwashima <kuniyu@...zon.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        David Ahern <dsahern@...nel.org>
Cc:     Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 2/2] 6lowpan: Remove redundant initialisation.



On 28/03/2023 2:54, Kuniyuki Iwashima wrote:
> We'll call memset(&tmp, 0, sizeof(tmp)) later.

Why not just remove the first memset() then?

Mark

> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> ---
>  net/6lowpan/iphc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/6lowpan/iphc.c b/net/6lowpan/iphc.c
> index 52fad5dad9f7..e116d308a8df 100644
> --- a/net/6lowpan/iphc.c
> +++ b/net/6lowpan/iphc.c
> @@ -848,7 +848,7 @@ static u8 lowpan_compress_ctx_addr(u8 **hc_ptr, const struct net_device *dev,
>  				   const struct lowpan_iphc_ctx *ctx,
>  				   const unsigned char *lladdr, bool sam)
>  {
> -	struct in6_addr tmp = {};
> +	struct in6_addr tmp;
>  	u8 dam;
>  
>  	switch (lowpan_dev(dev)->lltype) {