netdev - Re: [PATCH net 2/4] ice: Fix ice_cfg_rdma_fltr() to only update relevant fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230329120818.GQ831478@unreal>
Date:   Wed, 29 Mar 2023 15:08:18 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, netdev@...r.kernel.org,
        Brett Creeley <brett.creeley@...el.com>,
        Robert Malz <robertx.malz@...el.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Piotr Raczynski <piotr.raczynski@...el.com>,
        Jakub Andrysiak <jakub.andrysiak@...el.com>
Subject: Re: [PATCH net 2/4] ice: Fix ice_cfg_rdma_fltr() to only update
 relevant fields

On Tue, Mar 28, 2023 at 10:20:33AM -0700, Tony Nguyen wrote:
> From: Brett Creeley <brett.creeley@...el.com>
> 
> The current implementation causes ice_vsi_update() to update all VSI
> fields based on the cached VSI context. This also assumes that the
> ICE_AQ_VSI_PROP_Q_OPT_VALID bit is set. This can cause problems if the
> VSI context is not correctly synced by the driver. Fix this by only
> updating the fields that correspond to ICE_AQ_VSI_PROP_Q_OPT_VALID.
> Also, make sure to save the updated result in the cached VSI context
> on success.
> 
> Fixes: 348048e724a0 ("ice: Implement iidc operations")
> Co-developed-by: Robert Malz <robertx.malz@...el.com>
> Signed-off-by: Robert Malz <robertx.malz@...el.com>
> Signed-off-by: Brett Creeley <brett.creeley@...el.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Reviewed-by: Piotr Raczynski <piotr.raczynski@...el.com>
> Tested-by: Jakub Andrysiak <jakub.andrysiak@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_switch.c | 26 +++++++++++++++++----
>  1 file changed, 22 insertions(+), 4 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>