netdev - Re: [PATCH net 1/1] i40e: fix registers dump after run ethtool adapter self test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230329120922.GT831478@unreal>
Date:   Wed, 29 Mar 2023 15:09:22 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, netdev@...r.kernel.org,
        Radoslaw Tyl <radoslawx.tyl@...el.com>,
        Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
        Arpana Arland <arpanax.arland@...el.com>
Subject: Re: [PATCH net 1/1] i40e: fix registers dump after run ethtool
 adapter self test

On Tue, Mar 28, 2023 at 10:26:59AM -0700, Tony Nguyen wrote:
> From: Radoslaw Tyl <radoslawx.tyl@...el.com>
> 
> Fix invalid registers dump from ethtool -d ethX after adapter self test
> by ethtool -t ethY. It causes invalid data display.
> 
> The problem was caused by overwriting i40e_reg_list[].elements
> which is common for ethtool self test and dump.
> 
> Fixes: 22dd9ae8afcc ("i40e: Rework register diagnostic")
> Signed-off-by: Radoslaw Tyl <radoslawx.tyl@...el.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Tested-by: Arpana Arland <arpanax.arland@...el.com> (A Contingent worker at Intel)
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_diag.c | 11 ++++++-----
>  drivers/net/ethernet/intel/i40e/i40e_diag.h |  2 +-
>  2 files changed, 7 insertions(+), 6 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>