netdev - Re: [PATCH net] bnx2x: use the right build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230329123533.GU831478@unreal>
Date:   Wed, 29 Mar 2023 15:35:33 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, Thomas Voegtle <tv@...96.de>,
        aelior@...vell.com, skalluru@...vell.com, manishc@...vell.com,
        keescook@...omium.org
Subject: Re: [PATCH net] bnx2x: use the right build_skb() helper

On Tue, Mar 28, 2023 at 05:00:13PM -0700, Jakub Kicinski wrote:
> build_skb() no longer accepts slab buffers. Since slab use is fairly
> uncommon we prefer the drivers to call a separate slab_build_skb()
> function appropriately.
> 
> bnx2x uses the old semantics where size of 0 meant buffer from slab.
> It sets the fp->rx_frag_size to 0 for MTUs which don't fit in a page.
> It needs to call slab_build_skb().
> 
> This fixes the WARN_ONCE() of incorrect API use seen with bnx2x.
> 
> Reported-by: Thomas Voegtle <tv@...96.de>
> Link: https://lore.kernel.org/all/b8f295e4-ba57-8bfb-7d9c-9d62a498a727@lio96.de/
> Fixes: ce098da1497c ("skbuff: Introduce slab_build_skb()")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: aelior@...vell.com
> CC: skalluru@...vell.com
> CC: manishc@...vell.com
> CC: keescook@...omium.org
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>