| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZCQ2lr6/ITBdBqce@ashyti-mobl2.lan>
Date: Wed, 29 Mar 2023 15:01:10 +0200
From: Andi Shyti <andi.shyti@...ux.intel.com>
To: Andrzej Hajda <andrzej.hajda@...el.com>
Cc: Jani Nikula <jani.nikula@...ux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@...el.com>,
Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>, linux-kernel@...r.kernel.org,
intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
Chris Wilson <chris@...is-wilson.co.uk>,
netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Dmitry Vyukov <dvyukov@...gle.com>,
"David S. Miller" <davem@...emloft.net>,
Andi Shyti <andi.shyti@...ux.intel.com>
Subject: Re: [PATCH v6 0/8] drm/i915: use ref_tracker library for tracking
wakerefs
Eric, David (Miller),
Could you please check the ref_tracker portion of this series?
This patch has reached its 6th version, and we need your approval
to proceed.
Thank you,
Andi
On Wed, Mar 29, 2023 at 09:24:12AM +0200, Andrzej Hajda wrote:
> Gently ping for network developers, could you look at ref_tracker patches,
> as the ref_tracker library was developed for network.
>
> This is revived patchset improving ref_tracker library and converting
> i915 internal tracker to ref_tracker.
> The old thread ended without consensus about small kernel allocations,
> which are performed under spinlock.
> I have tried to solve the problem by splitting the calls, but it results
> in complicated API, so I went back to original solution.
> If there are better solutions I am glad to discuss them.
> Meanwhile I send original patchset with addressed remaining comments.
>
> To: Jani Nikula <jani.nikula@...ux.intel.com>
> To: Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>
> To: Rodrigo Vivi <rodrigo.vivi@...el.com>
> To: Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>
> To: David Airlie <airlied@...il.com>
> To: Daniel Vetter <daniel@...ll.ch>
> Cc: linux-kernel@...r.kernel.org
> Cc: intel-gfx@...ts.freedesktop.org
> Cc: dri-devel@...ts.freedesktop.org
> Cc: Chris Wilson <chris@...is-wilson.co.uk>
> Cc: netdev@...r.kernel.org
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Dmitry Vyukov <dvyukov@...gle.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Andi Shyti <andi.shyti@...ux.intel.com>
> Cc: Das, Nirmoy <nirmoy.das@...ux.intel.com>
> Signed-off-by: Andrzej Hajda <andrzej.hajda@...el.com>
>
> ---
> Changes in v6:
> - rebased to solve minor conflict and allow CI testing
> - Link to v5: https://lore.kernel.org/r/20230224-track_gt-v5-0-77be86f2c872@intel.com
>
> Changes in v5 (thx Andi for review):
> - use *_locked convention instead of __*,
> - improved commit messages,
> - re-worked i915 patches, squashed separation and conversion patches,
> - added tags,
> - Link to v4: https://lore.kernel.org/r/20230224-track_gt-v4-0-464e8ab4c9ab@intel.com
>
> Changes in v4:
> - split "Separate wakeref tracking" to smaller parts
> - fixed typos,
> - Link to v1-v3: https://patchwork.freedesktop.org/series/100327/
>
> ---
> Andrzej Hajda (7):
> lib/ref_tracker: add unlocked leak print helper
> lib/ref_tracker: improve printing stats
> lib/ref_tracker: add printing to memory buffer
> lib/ref_tracker: remove warnings in case of allocation failure
> drm/i915: Correct type of wakeref variable
> drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library
> drm/i915: track gt pm wakerefs
>
> Chris Wilson (1):
> drm/i915/gt: Hold a wakeref for the active VM
>
> drivers/gpu/drm/i915/Kconfig.debug | 19 ++
> drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 7 +-
> .../drm/i915/gem/selftests/i915_gem_coherency.c | 10 +-
> drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 14 +-
> drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 13 +-
> drivers/gpu/drm/i915/gt/intel_breadcrumbs_types.h | 3 +-
> drivers/gpu/drm/i915/gt/intel_context.h | 15 +-
> drivers/gpu/drm/i915/gt/intel_context_types.h | 2 +
> drivers/gpu/drm/i915/gt/intel_engine_pm.c | 10 +-
> drivers/gpu/drm/i915/gt/intel_engine_types.h | 2 +
> .../gpu/drm/i915/gt/intel_execlists_submission.c | 2 +-
> drivers/gpu/drm/i915/gt/intel_gt_pm.c | 12 +-
> drivers/gpu/drm/i915/gt/intel_gt_pm.h | 38 +++-
> drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 4 +-
> drivers/gpu/drm/i915/gt/selftest_engine_cs.c | 20 +-
> drivers/gpu/drm/i915/gt/selftest_gt_pm.c | 5 +-
> drivers/gpu/drm/i915/gt/selftest_reset.c | 10 +-
> drivers/gpu/drm/i915/gt/selftest_rps.c | 17 +-
> drivers/gpu/drm/i915/gt/selftest_slpc.c | 5 +-
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 11 +-
> drivers/gpu/drm/i915/i915_driver.c | 2 +-
> drivers/gpu/drm/i915/i915_pmu.c | 16 +-
> drivers/gpu/drm/i915/intel_runtime_pm.c | 221 ++-------------------
> drivers/gpu/drm/i915/intel_runtime_pm.h | 11 +-
> drivers/gpu/drm/i915/intel_wakeref.c | 7 +-
> drivers/gpu/drm/i915/intel_wakeref.h | 99 ++++++++-
> include/linux/ref_tracker.h | 31 ++-
> lib/ref_tracker.c | 179 ++++++++++++++---
> 29 files changed, 456 insertions(+), 331 deletions(-)
> ---
> base-commit: d4c9fe2c8c9b66c5e5954f6ded7bc934dd6afe3e
> change-id: 20230224-track_gt-1b3da8bdacd7
>
> Best regards,
> --
> Andrzej Hajda <andrzej.hajda@...el.com>
Powered by blists - more mailing lists