netdev - Re: [PATCH net 2/3] bnxt_en: Fix typo in PCI id to device description string mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCQ4XCOmE24jod9X@corigine.com>
Date:   Wed, 29 Mar 2023 15:08:44 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Michael Chan <michael.chan@...adcom.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, gospo@...adcom.com,
        Kalesh AP <kalesh-anakkur.purayil@...adcom.com>,
        Pavan Chebbi <pavan.chebbi@...adcom.com>
Subject: Re: [PATCH net 2/3] bnxt_en: Fix typo in PCI id to device
 description string mapping

On Tue, Mar 28, 2023 at 06:30:20PM -0700, Michael Chan wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
> 
> Fix 57502 and 57508 NPAR description string entries.  The typos
> caused these devices to not match up with lspci output.
> 
> Fixes: 49c98421e6ab ("bnxt_en: Add PCI IDs for 57500 series NPAR devices.")
> Reviewed-by: Pavan Chebbi <pavan.chebbi@...adcom.com>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>

Note: I checked that this corresponds to
      https://pci-ids.ucw.cz/read/PC/14e4

> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index e2e2c986c82b..c23e3b397bcf 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -175,12 +175,12 @@ static const struct pci_device_id bnxt_pci_tbl[] = {
>  	{ PCI_VDEVICE(BROADCOM, 0x1750), .driver_data = BCM57508 },
>  	{ PCI_VDEVICE(BROADCOM, 0x1751), .driver_data = BCM57504 },
>  	{ PCI_VDEVICE(BROADCOM, 0x1752), .driver_data = BCM57502 },
> -	{ PCI_VDEVICE(BROADCOM, 0x1800), .driver_data = BCM57508_NPAR },
> +	{ PCI_VDEVICE(BROADCOM, 0x1800), .driver_data = BCM57502_NPAR },
>  	{ PCI_VDEVICE(BROADCOM, 0x1801), .driver_data = BCM57504_NPAR },
> -	{ PCI_VDEVICE(BROADCOM, 0x1802), .driver_data = BCM57502_NPAR },
> -	{ PCI_VDEVICE(BROADCOM, 0x1803), .driver_data = BCM57508_NPAR },
> +	{ PCI_VDEVICE(BROADCOM, 0x1802), .driver_data = BCM57508_NPAR },
> +	{ PCI_VDEVICE(BROADCOM, 0x1803), .driver_data = BCM57502_NPAR },
>  	{ PCI_VDEVICE(BROADCOM, 0x1804), .driver_data = BCM57504_NPAR },
> -	{ PCI_VDEVICE(BROADCOM, 0x1805), .driver_data = BCM57502_NPAR },
> +	{ PCI_VDEVICE(BROADCOM, 0x1805), .driver_data = BCM57508_NPAR },
>  	{ PCI_VDEVICE(BROADCOM, 0xd802), .driver_data = BCM58802 },
>  	{ PCI_VDEVICE(BROADCOM, 0xd804), .driver_data = BCM58804 },
>  #ifdef CONFIG_BNXT_SRIOV
> -- 
> 2.18.1
>