lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e128356a-f56f-4c02-7437-dfea38e4194b@suse.de>
Date:   Wed, 29 Mar 2023 16:23:51 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     David Howells <dhowells@...hat.com>,
        Matthew Wilcox <willy@...radead.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     linux-doc@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, linux-mm@...ck.org,
        linux-sctp@...r.kernel.org, linux-afs@...ts.infradead.org,
        rds-devel@....oracle.com, linux-x25@...r.kernel.org,
        dccp@...r.kernel.org, linux-rdma@...r.kernel.org,
        Christoph Hellwig <hch@...radead.org>,
        linux-wpan@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-can@...r.kernel.org, Marc Kleine-Budde <mkl@...gutronix.de>,
        Al Viro <viro@...iv.linux.org.uk>, linux-hams@...r.kernel.org,
        mptcp@...ts.linux.dev, Jens Axboe <axboe@...nel.dk>,
        Christian Brauner <brauner@...nel.org>, netdev@...r.kernel.org,
        Jeff Layton <jlayton@...nel.org>, linux-kernel@...r.kernel.org,
        Chuck Lever III <chuck.lever@...cle.com>,
        tipc-discussion@...ts.sourceforge.net,
        linux-crypto@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        bpf@...r.kernel.org, Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [RFC PATCH v2 48/48] sock: Remove ->sendpage*() in favour of
 sendmsg(MSG_SPLICE_PAGES)

On 3/29/23 16:13, David Howells wrote:
> [!] Note: This is a work in progress.  At the moment, some things won't
>      build if this patch is applied.  nvme, kcm, smc, tls.
> 
> Remove ->sendpage() and ->sendpage_locked().  sendmsg() with
> MSG_SPLICE_PAGES should be used instead.  This allows multiple pages and
> multipage folios to be passed through.
> 
> Signed-off-by: David Howells <dhowells@...hat.com>
> Acked-by: Marc Kleine-Budde <mkl@...gutronix.de> # for net/can
> cc: "David S. Miller" <davem@...emloft.net>
> cc: Eric Dumazet <edumazet@...gle.com>
> cc: Jakub Kicinski <kuba@...nel.org>
> cc: Paolo Abeni <pabeni@...hat.com>
> cc: Jens Axboe <axboe@...nel.dk>
> cc: Matthew Wilcox <willy@...radead.org>
> cc: bpf@...r.kernel.org
> cc: dccp@...r.kernel.org
> cc: linux-afs@...ts.infradead.org
> cc: linux-arm-msm@...r.kernel.org
> cc: linux-can@...r.kernel.org
> cc: linux-crypto@...r.kernel.org
> cc: linux-doc@...r.kernel.org
> cc: linux-hams@...r.kernel.org
> cc: linux-kernel@...r.kernel.org
> cc: linux-rdma@...r.kernel.org
> cc: linux-sctp@...r.kernel.org
> cc: linux-wpan@...r.kernel.org
> cc: linux-x25@...r.kernel.org
> cc: mptcp@...ts.linux.dev
> cc: netdev@...r.kernel.org
> cc: rds-devel@....oracle.com
> cc: tipc-discussion@...ts.sourceforge.net
> cc: virtualization@...ts.linux-foundation.org
> ---
>   Documentation/networking/scaling.rst |   4 +-
>   crypto/af_alg.c                      |  29 ------
>   crypto/algif_aead.c                  |  22 +----
>   crypto/algif_rng.c                   |   2 -
>   crypto/algif_skcipher.c              |  14 ---
>   include/linux/net.h                  |   8 --
>   include/net/inet_common.h            |   2 -
>   include/net/sock.h                   |   6 --
>   net/appletalk/ddp.c                  |   1 -
>   net/atm/pvc.c                        |   1 -
>   net/atm/svc.c                        |   1 -
>   net/ax25/af_ax25.c                   |   1 -
>   net/caif/caif_socket.c               |   2 -
>   net/can/bcm.c                        |   1 -
>   net/can/isotp.c                      |   1 -
>   net/can/j1939/socket.c               |   1 -
>   net/can/raw.c                        |   1 -
>   net/core/sock.c                      |  35 +------
>   net/dccp/ipv4.c                      |   1 -
>   net/dccp/ipv6.c                      |   1 -
>   net/ieee802154/socket.c              |   2 -
>   net/ipv4/af_inet.c                   |  21 ----
>   net/ipv4/tcp.c                       |  34 -------
>   net/ipv4/tcp_bpf.c                   |  21 +---
>   net/ipv4/tcp_ipv4.c                  |   1 -
>   net/ipv4/udp.c                       |  22 -----
>   net/ipv4/udp_impl.h                  |   2 -
>   net/ipv4/udplite.c                   |   1 -
>   net/ipv6/af_inet6.c                  |   3 -
>   net/ipv6/raw.c                       |   1 -
>   net/ipv6/tcp_ipv6.c                  |   1 -
>   net/key/af_key.c                     |   1 -
>   net/l2tp/l2tp_ip.c                   |   1 -
>   net/l2tp/l2tp_ip6.c                  |   1 -
>   net/llc/af_llc.c                     |   1 -
>   net/mctp/af_mctp.c                   |   1 -
>   net/mptcp/protocol.c                 |   2 -
>   net/netlink/af_netlink.c             |   1 -
>   net/netrom/af_netrom.c               |   1 -
>   net/packet/af_packet.c               |   2 -
>   net/phonet/socket.c                  |   2 -
>   net/qrtr/af_qrtr.c                   |   1 -
>   net/rds/af_rds.c                     |   1 -
>   net/rose/af_rose.c                   |   1 -
>   net/rxrpc/af_rxrpc.c                 |   1 -
>   net/sctp/protocol.c                  |   1 -
>   net/socket.c                         |  48 ---------
>   net/tipc/socket.c                    |   3 -
>   net/unix/af_unix.c                   | 139 ---------------------------
>   net/vmw_vsock/af_vsock.c             |   3 -
>   net/x25/af_x25.c                     |   1 -
>   net/xdp/xsk.c                        |   1 -
>   52 files changed, 9 insertions(+), 447 deletions(-)
> 
Weelll ... what happens to consumers of kernel_sendpage()?
(Let's call them nvme ...)
Should they be moved over, too?

Or what is the general consensus here?

(And what do we do with TLS? It does have a ->sendpage() version, too ...)

Cheers,

Hannes

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ