netdev - Re: [RFC PATCH v2 48/48] sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Mar 2023 15:39:33 +0100
From:   David Howells <dhowells@...hat.com>
To:     Hannes Reinecke <hare@...e.de>
cc:     David Howells <dhowells@...hat.com>,
        Matthew Wilcox <willy@...radead.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-doc@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, linux-mm@...ck.org,
        linux-sctp@...r.kernel.org, linux-afs@...ts.infradead.org,
        rds-devel@....oracle.com, linux-x25@...r.kernel.org,
        dccp@...r.kernel.org, linux-rdma@...r.kernel.org,
        Christoph Hellwig <hch@...radead.org>,
        linux-wpan@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-can@...r.kernel.org, Marc Kleine-Budde <mkl@...gutronix.de>,
        Al Viro <viro@...iv.linux.org.uk>, linux-hams@...r.kernel.org,
        mptcp@...ts.linux.dev, Jens Axboe <axboe@...nel.dk>,
        Christian Brauner <brauner@...nel.org>, netdev@...r.kernel.org,
        Jeff Layton <jlayton@...nel.org>, linux-kernel@...r.kernel.org,
        Chuck Lever III <chuck.lever@...cle.com>,
        tipc-discussion@...ts.sourceforge.net,
        linux-crypto@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        bpf@...r.kernel.org, Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [RFC PATCH v2 48/48] sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)

Hannes Reinecke <hare@...e.de> wrote:

> > [!] Note: This is a work in progress.  At the moment, some things won't
> >      build if this patch is applied.  nvme, kcm, smc, tls.

Actually, that needs updating.  nvme and smc now build.

> Weelll ... what happens to consumers of kernel_sendpage()?
> (Let's call them nvme ...)
> Should they be moved over, too?

Patch 42 should address NVMe, I think.  I can't test it, though, as I don't
have hardware.

There should be no callers of kernel_sendmsg() by the end of this patchset,
and the only remaining implementors of sendpage are Chelsio-TLS, AF_TLS and
AF_KCM, which as stated in the cover, aren't yet converted and won't build.

> Or what is the general consensus here?
> 
> (And what do we do with TLS? It does have a ->sendpage() version, too ...)

I know.  There are three things left that I need to tackle, but I'd like to
get opinions on some of the other bits and I might need some help with AF_TLS
and AF_KCM.

That said, should I just remove tls_sw_do_sendpage() since presumably the data
is going to get copied(?) and encrypted and the source pages aren't going to
be held onto?

David