netdev - Re: [PATCH iproute2-next] macvlan: Add bclim parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b52bb122-b5e2-cff1-1c0a-ad8a855e278d@gmail.com>
Date:   Wed, 29 Mar 2023 08:51:50 -0600
From:   David Ahern <dsahern@...il.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] macvlan: Add bclim parameter

On 3/27/23 9:02 PM, Herbert Xu wrote:
> @@ -67,6 +68,12 @@ static int bc_queue_len_arg(const char *arg)
>  	return -1;
>  }
>  
> +static int bclim_arg(const char *arg)
> +{
> +	fprintf(stderr, "Error: illegal value for \"bclen\": \"%s\"\n", arg);

s/bclen/bclim/?

> +	return -1;
> +}
> +
>  static int macvlan_parse_opt(struct link_util *lu, int argc, char **argv,
>  			  struct nlmsghdr *n)
>  {
> @@ -168,6 +175,15 @@ static int macvlan_parse_opt(struct link_util *lu, int argc, char **argv,
>  				return bc_queue_len_arg(*argv);
>  			}
>  			addattr32(n, 1024, IFLA_MACVLAN_BC_QUEUE_LEN, bc_queue_len);
> +		} else if (matches(*argv, "bclim") == 0) {

we stopped accepting new uses of `matches`; make this strcmp.