[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <PH0PR18MB4474D7DA8B343FB842A9E649DE899@PH0PR18MB4474.namprd18.prod.outlook.com>
Date: Wed, 29 Mar 2023 17:19:38 +0000
From: Hariprasad Kelam <hkelam@...vell.com>
To: Simon Horman <simon.horman@...igine.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"kuba@...nel.org" <kuba@...nel.org>,
"davem@...emloft.net" <davem@...emloft.net>,
"willemdebruijn.kernel@...il.com" <willemdebruijn.kernel@...il.com>,
"andrew@...n.ch" <andrew@...n.ch>,
Sunil Kovvuri Goutham <sgoutham@...vell.com>,
Linu Cherian <lcherian@...vell.com>,
Geethasowjanya Akula <gakula@...vell.com>,
Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
"naveenm@...vel.com" <naveenm@...vel.com>,
"edumazet@...gle.com" <edumazet@...gle.com>,
"pabeni@...hat.com" <pabeni@...hat.com>,
"jhs@...atatu.com" <jhs@...atatu.com>,
"xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
"jiri@...nulli.us" <jiri@...nulli.us>,
"maxtram95@...il.com" <maxtram95@...il.com>
Subject: Re: [net-next Patch v5 3/6] octeontx2-pf: qos send queues management
> On Sun, Mar 26, 2023 at 11:42:42PM +0530, Hariprasad Kelam wrote:
> > From: Subbaraya Sundeep <sbhatta@...vell.com>
> >
> > Current implementation is such that the number of Send queues (SQs)
> > are decided on the device probe which is equal to the number of online
> > cpus. These SQs are allocated and deallocated in interface open and c
> > lose calls respectively.
> >
> > This patch defines new APIs for initializing and deinitializing Send
> > queues dynamically and allocates more number of transmit queues for
> > QOS feature.
> >
> > Signed-off-by: Subbaraya Sundeep <sbhatta@...vell.com>
> > Signed-off-by: Hariprasad Kelam <hkelam@...vell.com>
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@...vell.com>
>
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
>
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>
> ...
>
> > @@ -1938,6 +1952,12 @@ static netdev_tx_t otx2_xmit(struct sk_buff
> *skb, struct net_device *netdev)
> > int qidx = skb_get_queue_mapping(skb);
> > struct otx2_snd_queue *sq;
> > struct netdev_queue *txq;
> > + int sq_idx;
> > +
> > + /* XDP SQs are not mapped with TXQs
> > + * advance qid to derive correct sq maped with QOS
>
> nit: s/maped/mapped/
>
ACK , will add the change in next version.
Thanks,
Hariprasad k
> ...
Powered by blists - more mailing lists