netdev - Re: [PATCH net 1/3] bnxt_en: Fix reporting of test result in ethtool selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Mar 2023 10:34:28 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, gospo@...adcom.com,
        Kalesh AP <kalesh-anakkur.purayil@...adcom.com>,
        Pavan Chebbi <pavan.chebbi@...adcom.com>,
        Somnath Kotur <somnath.kotur@...adcom.com>
Subject: Re: [PATCH net 1/3] bnxt_en: Fix reporting of test result in ethtool selftest

On Wed, Mar 29, 2023 at 6:08 AM Simon Horman <simon.horman@...igine.com> wrote:
>
> On Tue, Mar 28, 2023 at 06:30:19PM -0700, Michael Chan wrote:
> > From: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
> >
> > When the selftest command fails, driver is not reporting the failure
> > by updating the "test->flags" when bnxt_close_nic() fails.
> >
> > Fixes: eb51365846bc ("bnxt_en: Add basic ethtool -t selftest support.")
> > Reviewed-by: Pavan Chebbi <pavan.chebbi@...adcom.com>
> > Reviewed-by: Somnath Kotur <somnath.kotur@...adcom.com>
> > Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
> > Signed-off-by: Michael Chan <michael.chan@...adcom.com>
>
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
>
> Note: I think this will require a manual backport to get
>       all the way back to the above referenced commit (v4.12).
>       I'm unsure if that will need to be addressed in practice.

Thanks for the review.  The manual backport should be relatively
trivial.  But I agree that it may not be necessary to backport all the
way back for this minor issue.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)