netdev - Re: [PATCH net-next 01/11] can: rcar_canfd: Add transceiver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 29 Mar 2023 08:42:56 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Marc Kleine-Budde <mkl@...gutronix.de>, netdev@...r.kernel.org,
        davem@...emloft.net, linux-can@...r.kernel.org,
        kernel@...gutronix.de,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Simon Horman <simon.horman@...igine.com>,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>
Subject: Re: [PATCH net-next 01/11] can: rcar_canfd: Add transceiver support

Hi Jakub,

On Tue, Mar 28, 2023 at 11:57 PM Jakub Kicinski <kuba@...nel.org> wrote:
> On Mon, 27 Mar 2023 09:33:44 +0200 Marc Kleine-Budde wrote:
> > @@ -1836,6 +1849,7 @@ static void rcar_canfd_channel_remove(struct rcar_canfd_global *gpriv, u32 ch)
> >
> >  static int rcar_canfd_probe(struct platform_device *pdev)
> >  {
> > +     struct phy *transceivers[RCANFD_NUM_CHANNELS] = { 0, };
> >       const struct rcar_canfd_hw_info *info;
> >       struct device *dev = &pdev->dev;
> >       void __iomem *addr;
>
> [somehow this got stuck in my outgoing mail]
>
> drivers/net/can/rcar/rcar_canfd.c:1852:59: warning: Using plain integer as NULL pointer
>
> Could you follow up with a fix fix?

Sure (that one was well hidden in the sparse output)

https://lore.kernel.org/r/7f7b0dde0caa2d2977b4fb5b65b63036e75f5022.1680071972.git.geert+renesas@glider.be
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds