netdev - Re: [PATCH] can: rcar_canfd: Fix plain integer in transceivers[] init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CRIP3MJO75K3.5ZIJWJZFYIU1@den-dk-m31857>
Date:   Wed, 29 Mar 2023 07:40:16 +0000
From:   <Steen.Hegelund@...rochip.com>
To:     <geert+renesas@...der.be>, <wg@...ndegger.com>,
        <mkl@...gutronix.de>, <kuba@...nel.org>
CC:     <linux-can@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH] can: rcar_canfd: Fix plain integer in transceivers[] init

Hi Geert,

Looks fine to me.

On Wed Mar 29, 2023 at 8:40 AM CEST, Geert Uytterhoeven wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> With C=1:
>
>     drivers/net/can/rcar/rcar_canfd.c:1852:59: warning: Using plain integer as NULL pointer
>
> Fixes: a0340df7eca4f28e ("can: rcar_canfd: Add transceiver support")
> Reported-by: Jakub Kicinski <kuba@...nel.org>
> Link: https://lore.kernel.org/r/20230328145658.7fdbc394@kernel.org
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  drivers/net/can/rcar/rcar_canfd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_canfd.c
> index ecdb8ffe2f670c9b..11626d2a0afb1a90 100644
> --- a/drivers/net/can/rcar/rcar_canfd.c
> +++ b/drivers/net/can/rcar/rcar_canfd.c
> @@ -1848,7 +1848,7 @@ static void rcar_canfd_channel_remove(struct rcar_canfd_global *gpriv, u32 ch)
>
>  static int rcar_canfd_probe(struct platform_device *pdev)
>  {
> -       struct phy *transceivers[RCANFD_NUM_CHANNELS] = { 0, };
> +       struct phy *transceivers[RCANFD_NUM_CHANNELS] = { NULL, };
>         const struct rcar_canfd_hw_info *info;
>         struct device *dev = &pdev->dev;
>         void __iomem *addr;
> --
> 2.34.1


Reviewed-by: Steen Hegelund <Steen.Hegelund@...rochip.com>

BR
Steen