netdev - Re: [PATCH] net: Fix invalid ip_route_output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZCVApoRV/myYz1Hx@gauss3.secunet.de>
Date:   Thu, 30 Mar 2023 09:56:22 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Tudor Ambarus <tudordana@...gle.com>
CC:     Hyunwoo Kim <v4bel@...ori.io>, Eric Dumazet <edumazet@...gle.com>,
        "Taehee Yoo" <ap420073@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Dmitry Kozlov <xeb@...l.ru>,
        David Ahern <dsahern@...nel.org>, <netdev@...r.kernel.org>,
        <imv4bel@...il.com>, Lee Jones <joneslee@...gle.com>
Subject: Re: [PATCH] net: Fix invalid ip_route_output_ports() call

On Thu, Mar 30, 2023 at 08:42:56AM +0100, Tudor Ambarus wrote:
> Hi, Steffen!
> 
> On 3/24/23 09:57, Steffen Klassert wrote:
> > 
> > I plan to fix this with the patch below. With this, the above policy
> > should be rejected. It still needs a bit of testing to make sure that
> > I prohibited no valid usecase with it.
> > 
> > ---
> > Subject: [PATCH RFC ipsec] xfrm: Don't allow optional intermediate templates that
> >  changes the address family
> > 
> > When an optional intermediate template changes the address family,
> > it is unclear which family the next template should have. This can
> > lead to misinterpretations of IPv4/IPv6 addresses. So reject
> > optional intermediate templates on insertion time.
> > 
> > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > Reported-by: Hyunwoo Kim <v4bel@...ori.io>
> > Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>
> > ---
> >  net/xfrm/xfrm_user.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> 
> What's the status of this patch? I'm asking because LTS kernels are
> affected and we'll have to fix them too. I tried searching for a related
> patch on public ml archives and into the IPSEC repositories and I
> couldn't find one.

I'll likely submit that patch tomorrow. I will go to the ipsec tree
soon, if there are no objections on the list.