netdev - Re: [RFC PATCH 2/2] mac80211: use the new drop reasons infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Mar 2023 10:14:43 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [RFC PATCH 2/2] mac80211: use the new drop reasons
 infrastructure

On Wed, 2023-03-29 at 21:06 -0700, Jakub Kicinski wrote:
> On Wed, 29 Mar 2023 23:56:31 +0200 Johannes Berg wrote:
> > > +	drop_reasons_unregister_subsys(SKB_DROP_REASON_SUBSYS_MAC80211_MONITOR);
> > > +	drop_reasons_unregister_subsys(SKB_DROP_REASON_SUBSYS_MAC80211_UNUSABLE);
> > > +
> > >  	rcu_barrier();  
> > 
> > This is making me think that perhaps we don't want synchronize_rcu()
> > inside drop_reasons_unregister_subsys(), since I have two now and also
> > already have an rcu_barrier() ... so maybe just document that it's
> > needed?
> 
> premature optimization? some workload is reloading mac80211 in a loop?

Yeah, true, nobody is going to do that :-)

Let's leave it this way.

johannes