netdev - Re: [PATCH 4/5] serial: 8250_tegra: Add explicit include for of.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <502523a9-9737-d9ce-8ee5-ca8d39fc0c52@nvidia.com>
Date:   Thu, 30 Mar 2023 09:50:31 +0100
From:   Jon Hunter <jonathanh@...dia.com>
To:     Rob Herring <robh@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Marcelo Schmitt <marcelo.schmitt1@...il.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Johannes Berg <johannes@...solutions.net>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Marc Zyngier <maz@...nel.org>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-acpi@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 4/5] serial: 8250_tegra: Add explicit include for of.h


On 29/03/2023 22:20, Rob Herring wrote:
> With linux/acpi.h no longer implicitly including of.h, add an explicit
> include of of.h to fix the following error:
> 
> drivers/tty/serial/8250/8250_tegra.c:68:15: error: implicit declaration of function 'of_alias_get_id' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>   drivers/tty/serial/8250/8250_tegra.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/8250/8250_tegra.c b/drivers/tty/serial/8250/8250_tegra.c
> index e7cddeec9d8e..2509e7f74ccf 100644
> --- a/drivers/tty/serial/8250/8250_tegra.c
> +++ b/drivers/tty/serial/8250/8250_tegra.c
> @@ -11,6 +11,7 @@
>   #include <linux/delay.h>
>   #include <linux/io.h>
>   #include <linux/module.h>
> +#include <linux/of.h>
>   #include <linux/reset.h>
>   #include <linux/slab.h>
>   
> 


Reviewed-by: Jon Hunter <jonathanh@...dia.com>

Thanks!
Jon

-- 
nvpublic