lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Mar 2023 19:41:26 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Yinjun Zhang <yinjun.zhang@...igine.com> Cc: Louis Peens <louis.peens@...igine.com>, David Miller <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <simon.horman@...igine.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, oss-drivers <oss-drivers@...igine.com> Subject: Re: [PATCH net-next 2/2] nfp: separate the port's upper state with lower phy state On Thu, 30 Mar 2023 01:56:13 +0000 Yinjun Zhang wrote: > On Wed, 29 Mar 2023 12:24:22 -0700, Jakub Kicinski wrote: > > On Wed, 29 Mar 2023 16:45:48 +0200 Louis Peens wrote: > > > For nic application firmware, enable the ports' phy state at the > > > beginning. And by default its state doesn't change in pace with > > > the upper state, unless the ethtool private flag "link_state_detach" > > > is turned off by: > > > > > > ethtool --set-private-flags <netdev> link_state_detach off > > > > > > With this separation, we're able to keep the VF state up while > > > bringing down the PF. > > > > This commit message is very confusing. Please rewrite it. > > How about > " > With this separation, the lower phy state of uplink port can be kept > link-on no matter what the upper admin state is. What is "upper", in this context? grep the networking code for upper, is that what you mean? > Thus the corresponding > VFs can also link up and communicate with exterior through the uplink > port. > "
Powered by blists - more mailing lists