netdev - Re: [PATCH net] net: dsa: mv88e6xxx: Enable IGMP snooping on user ports only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230330120819.yfyzdiixqef657di@skbuf>
Date:   Thu, 30 Mar 2023 15:08:19 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     kuba@...nel.org, andrew@...n.ch, netdev@...r.kernel.org,
        steffen@...osonix.de, Fabio Estevam <festevam@...x.de>
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Enable IGMP snooping on user
 ports only

On Wed, Mar 29, 2023 at 12:01:40PM -0300, Fabio Estevam wrote:
> From: Steffen Bätz <steffen@...osonix.de>
> 
> Do not set the MV88E6XXX_PORT_CTL0_IGMP_MLD_SNOOP bit on CPU or DSA ports.
> 
> This allows the host CPU port to be a regular IGMP listener by sending out
> IGMP Membership Reports, which would otherwise not be forwarded by the
> mv88exxx chip, but directly looped back to the CPU port itself.
> 
> Fixes: 54d792f257c6 ("net: dsa: Centralise global and port setup code into mv88e6xxx.")

I checked to see if the Fixes tag is correct, and... it's complicated.
That patch comes from the consolidation of multiple drivers
(mv88e6123_61_65.c, mv88e6131.c, mv88e6171.c, mv88e6352.c into what
later became the common mv88e6xxx driver. In principle, each of the
above drivers had their own buggy pre-existing logic to enable IGMP/MLD
snooping on all ports, but it seems a pointless exercise to add
individual Fixes: tags for all drivers prior to an unification process
that took place in 2015. So this gets my:

Reviewed-by: Vladimir Oltean <olteanv@...il.com>