netdev - Re: [PATCH net 2/3] selftests: bonding: re-format bond option tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <301d2861-1390-eaea-4521-90d4dcfe7336@redhat.com>
Date:   Thu, 30 Mar 2023 12:45:11 -0400
From:   Jonathan Toppins <jtoppins@...hat.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     Jay Vosburgh <j.vosburgh@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>, Liang Li <liali@...hat.com>
Subject: Re: [PATCH net 2/3] selftests: bonding: re-format bond option tests

On 3/29/23 06:18, Hangbin Liu wrote:
> To improve the testing process for bond options, A new bond library is
> added to our testing setup. The current option_prio.sh file will be
> renamed to bond_options.sh so that all bonding options can be tested here.
> Specifically, for priority testing, we will run all tests using module
                                            I think you mean `modes`^^^
> 1, 5, and 6. These changes will help us streamline the testing process
> and ensure that our bond options are rigorously evaluated.
> 
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>   .../selftests/drivers/net/bonding/Makefile    |   3 +-
>   .../selftests/drivers/net/bonding/bond_lib.sh | 145 +++++++++++
>   .../drivers/net/bonding/bond_options.sh       | 216 +++++++++++++++
>   .../drivers/net/bonding/option_prio.sh        | 245 ------------------
>   4 files changed, 363 insertions(+), 246 deletions(-)
>   create mode 100644 tools/testing/selftests/drivers/net/bonding/bond_lib.sh
>   create mode 100755 tools/testing/selftests/drivers/net/bonding/bond_options.sh
>   delete mode 100755 tools/testing/selftests/drivers/net/bonding/option_prio.sh
> 
> diff --git a/tools/testing/selftests/drivers/net/bonding/Makefile b/tools/testing/selftests/drivers/net/bonding/Makefile
> index a39bb2560d9b..4683b06afdba 100644
> --- a/tools/testing/selftests/drivers/net/bonding/Makefile
> +++ b/tools/testing/selftests/drivers/net/bonding/Makefile
> @@ -8,11 +8,12 @@ TEST_PROGS := \
>   	dev_addr_lists.sh \
>   	mode-1-recovery-updelay.sh \
>   	mode-2-recovery-updelay.sh \
> -	option_prio.sh \
> +	bond_options.sh \
>   	bond-eth-type-change.sh
>   
>   TEST_FILES := \
>   	lag_lib.sh \
> +	bond_lib.sh \
>   	net_forwarding_lib.sh
>   
>   include ../../../lib.mk
> diff --git a/tools/testing/selftests/drivers/net/bonding/bond_lib.sh b/tools/testing/selftests/drivers/net/bonding/bond_lib.sh
> new file mode 100644
> index 000000000000..ca64a82e1385
> --- /dev/null
> +++ b/tools/testing/selftests/drivers/net/bonding/bond_lib.sh

I like this idea, we might want to separate network topology from 
library code however. That way a given test case can just include a 
predefined topology. A quick review of the test cases show a 2 node 
setup is the most common across all test cases.

-Jon