netdev - Re: [PATCH net-next] ethtool: reset #lanes when lanes is omitted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60bd2658-2bf6-0091-1dfa-171ab4fea3c2@nvidia.com>
Date:   Thu, 30 Mar 2023 11:18:53 -0700
From:   Andy Roulin <aroulin@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jiri@...dia.com,
        andrew@...n.ch, f.fainelli@...il.com, mkubecek@...e.cz,
        mlxsw@...dia.com, idosch@...dia.com,
        Danielle Ratson <danieller@...dia.com>
Subject: Re: [PATCH net-next] ethtool: reset #lanes when lanes is omitted

On 3/30/23 10:38 AM, Jakub Kicinski wrote:
> On Thu, 30 Mar 2023 09:56:58 -0700 Andy Roulin wrote:
>> Subject: [PATCH net-next] ethtool: reset #lanes when lanes is omitted
> 
> This should have been tagged for net, right?
>

Yes, sorry, I will resend.

>> If the number of lanes was forced and then subsequently the user
>> omits this parameter, the ksettings->lanes is reset. The driver
>> should then reset the number of lanes to the device's default
>> for the specified speed.
>>
>> However, although the ksettings->lanes is set to 0, the mod variable
>> is not set to true to indicate the driver and userspace should be
>> notified of the changes.
>>
>> Fixes: 012ce4dd3102 ("ethtool: Extend link modes settings uAPI with lanes")
>> Signed-off-by: Andy Roulin <aroulin@...dia.com>
>> Reviewed-by: Danielle Ratson <danieller@...dia.com>