[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZCXXIvvnTBch/0Oz@google.com>
Date: Thu, 30 Mar 2023 11:38:26 -0700
From: Stanislav Fomichev <sdf@...gle.com>
To: Jesper Dangaard Brouer <brouer@...hat.com>
Cc: bpf@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, martin.lau@...nel.org,
ast@...nel.org, daniel@...earbox.net, alexandr.lobakin@...el.com,
larysa.zaremba@...el.com, xdp-hints@...-project.net,
anthony.l.nguyen@...el.com, yoong.siang.song@...el.com,
boon.leong.ong@...el.com, intel-wired-lan@...ts.osuosl.org,
pabeni@...hat.com, jesse.brandeburg@...el.com, kuba@...nel.org,
edumazet@...gle.com, john.fastabend@...il.com, hawk@...nel.org,
davem@...emloft.net
Subject: Re: [PATCH bpf RFC-V3 0/5] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash
On 03/30, Jesper Dangaard Brouer wrote:
> Notice targeted 6.3-rc kernel via bpf git tree.
> Current API for bpf_xdp_metadata_rx_hash() returns the raw RSS hash value,
> but doesn't provide information on the RSS hash type (part of 6.3-rc).
> This patchset proposal is to change the function call signature via adding
> a pointer value argument for provide the RSS hash type.
> Alternatively we disable bpf_xdp_metadata_rx_hash() in 6.3-rc, and have
> more time to nitpick the RSS hash-type bits.
LGTM with one nit about EMIT_BTF.
> ---
> Jesper Dangaard Brouer (5):
> xdp: rss hash types representation
> mlx5: bpf_xdp_metadata_rx_hash add xdp rss hash type
> veth: bpf_xdp_metadata_rx_hash add xdp rss hash type
> mlx4: bpf_xdp_metadata_rx_hash add xdp rss hash type
> selftests/bpf: Adjust bpf_xdp_metadata_rx_hash for new arg
> drivers/net/ethernet/mellanox/mlx4/en_rx.c | 22 ++++++-
> drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 3 +-
> .../net/ethernet/mellanox/mlx5/core/en/xdp.c | 63 ++++++++++++++++++-
> drivers/net/veth.c | 11 +++-
> include/linux/mlx5/device.h | 14 ++++-
> include/linux/netdevice.h | 3 +-
> include/net/xdp.h | 49 +++++++++++++++
> net/core/xdp.c | 10 ++-
> .../selftests/bpf/prog_tests/xdp_metadata.c | 2 +
> .../selftests/bpf/progs/xdp_hw_metadata.c | 14 +++--
> .../selftests/bpf/progs/xdp_metadata.c | 6 +-
> .../selftests/bpf/progs/xdp_metadata2.c | 7 ++-
> tools/testing/selftests/bpf/xdp_hw_metadata.c | 2 +-
> tools/testing/selftests/bpf/xdp_metadata.h | 1 +
> 14 files changed, 183 insertions(+), 24 deletions(-)
> --
Powered by blists - more mailing lists