netdev - Re: [PATCH 12/16] virtio_net: introduce virtnet_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230329212203.3c3bf199@kernel.org>
Date:   Wed, 29 Mar 2023 21:22:03 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        virtualization@...ts.linux-foundation.org, bpf@...r.kernel.org
Subject: Re: [PATCH 12/16] virtio_net: introduce virtnet_get_netdev()

On Tue, 28 Mar 2023 17:28:43 +0800 Xuan Zhuo wrote:
> +const struct net_device_ops *virtnet_get_netdev(void)
> +{
> +	return &virtnet_netdev;
> +}

Why not just make the virtnet_netdev symbol visible?
Many drivers do that.

If you prefer the function maybe virtnet_get_ndos() would be a better
name for example? The current name sounds like it will get a... well..
a netdev. And it gets ops.