netdev - Re: [PATCH net-next] selftests: rtnetlink: Fix do_test_address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCUz7P66OGRJ9X2k@shredder>
Date:   Thu, 30 Mar 2023 10:02:04 +0300
From:   Ido Schimmel <idosch@...dia.com>
To:     Petr Machata <petrm@...dia.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH net-next] selftests: rtnetlink: Fix
 do_test_address_proto()

On Wed, Mar 29, 2023 at 05:24:53PM +0200, Petr Machata wrote:
> This selftest was introduced recently in the commit cited below. It misses
> several check_err() invocations to actually verify that the previous
> command succeeded. When these are added, the first one fails, because
> besides the addresses added by hand, there can be a link-local address
> added by the kernel. Adjust the check to expect at least three addresses
> instead of exactly three, and add the missing check_err's.
> 
> Furthermore, the explanatory comments assume that the address with no
> protocol is $addr2, when in fact it is $addr3. Update the comments.
> 
> Fixes: 6a414fd77f61 ("selftests: rtnetlink: Add an address proto test")
> Signed-off-by: Petr Machata <petrm@...dia.com>

Reviewed-by: Ido Schimmel <idosch@...dia.com>