netdev - Aw: Re: Re: Re: Re: Re: [PATCH net] net: ethernet: mtk_eth_soc: fix tx throughput regression with direct 1G links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 31 Mar 2023 14:46:32 +0200
From:   Frank Wunderlich <frank-w@...lic-files.de>
To:     Felix Fietkau <nbd@....name>
Cc:     netdev@...r.kernel.org, Daniel Golle <daniel@...rotopia.org>
Subject: Aw: Re:  Re: Re: Re: Re: [PATCH net] net: ethernet: mtk_eth_soc:
 fix tx throughput regression with direct 1G links



regards Frank


> Gesendet: Donnerstag, 30. März 2023 um 19:06 Uhr
> Von: "Felix Fietkau" <nbd@....name>
> An: "Frank Wunderlich" <frank-w@...lic-files.de>
> Cc: netdev@...r.kernel.org, "Daniel Golle" <daniel@...rotopia.org>
> Betreff: Re: Aw: Re: Re: Re: Re: [PATCH net] net: ethernet: mtk_eth_soc: fix tx throughput regression with direct 1G links
>
> On 30.03.23 15:58, Frank Wunderlich wrote:
> > something ist still strange...i get a rcu stall again with this patch...reverted it and my r2 boots again.
> > 
> > [   29.772755] rcu: INFO: rcu_sched detected stalls on CPUs/tasks:
> > [   29.778689] rcu:     2-...0: (1 GPs behind) idle=547c/1/0x40000000 softirq=251/258 fqs=427
> > [   29.786697] rcu:     (detected by 1, t=2104 jiffies, g=-875, q=29 ncpus=4)
> > [   29.793308] Sending NMI from CPU 1 to CPUs 2:
> > 
> > maybe i need additional patch or did anything else wrong?
> > 
> > still working on 6.3-rc1
> > https://github.com/frank-w/BPI-Router-Linux/commits/6.3-rc-net
> Can you try applying this patch to a stable kernel instead? These hangs 
> don't make any sense to me, especially the one triggered by an earlier 
> patch that should definitely have been a no-op because of the wrong 
> config symbol.
> It really looks to me like you have an issue in that kernel triggered by 
> spurious code changes.

Hi,

have applied it on top of 6.2.0 which has the "implement multi-queue support for per-port queues" in, and indeed it fixes the problem on mt7623.

thx for the fix, you can send it with my tested-tag

Tested-By: Frank Wunderlich <frank-w@...lic-files.de>

regards Frank