netdev - Re: [PATCH net v2] net: dsa: mv88e6xxx: Reset mv88e6393x force WD event bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 31 Mar 2023 05:49:57 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Gustav Ekelund <gustav.ekelund@...s.com>, marek.behun@....cz,
        Andrew Lunn <andrew@...n.ch>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     kernel@...s.com, Gustav Ekelund <gustaek@...s.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] net: dsa: mv88e6xxx: Reset mv88e6393x force WD
 event bit



On 3/31/2023 1:40 AM, Gustav Ekelund wrote:
> From: Gustav Ekelund <gustaek@...s.com>
> 
> The force watchdog event bit is not cleared during SW reset in the
> mv88e6393x switch. This is a different behavior compared to mv886390 which
> clears the force WD event bit as advertised. This causes a force WD event
> to be handled over and over again as the SW reset following the event never
> clears the force WD event bit.
> 
> Explicitly clear the watchdog event register to 0 in irq_action when
> handling an event to prevent the switch from sending continuous interrupts.
> Marvell aren't aware of any other stuck bits apart from the force WD
> bit.
> 
> Signed-off-by: Gustav Ekelund <gustaek@...s.com>

Would that deserve:

Fixes: de776d0d316f ("net: dsa: mv88e6xxx: add support for mv88e6393x 
family")

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian