netdev - Re: [PATCH iproute2] ip-xfrm: accept "allow" as action in ip xfrm policy setdefault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dde9340f-4e44-3d51-b1b1-840d0f166b08@6wind.com>
Date:   Fri, 31 Mar 2023 15:29:42 +0200
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Sabrina Dubroca <sd@...asysnail.net>, netdev@...r.kernel.org
Cc:     dsahern@...il.com, stephen@...workplumber.org
Subject: Re: [PATCH iproute2] ip-xfrm: accept "allow" as action in ip xfrm
 policy setdefault

Le 31/03/2023 à 15:18, Sabrina Dubroca a écrit :
> The help text claims that setdefault takes ACTION values, ie block |
> allow. In reality, xfrm_str_to_policy takes block | accept.
> 
> We could also fix that by changing the help text/manpage, but then
> it'd be frustrating to have multiple ACTION with similar values used
> in different subcommands.
> 
> I'm not changing the output in xfrm_policy_to_str because some
> userspace somewhere probably depends on the "accept" value.
> 
> Fixes: 76b30805f9f6 ("xfrm: enable to manage default policies")
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>