netdev - Re: [PATCH net-next v3 2/4] net/mlx5: Support MACsec over VLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCbkyXyhXEsULUVh@corigine.com>
Date:   Fri, 31 Mar 2023 15:48:57 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Emeel Hakim <ehakim@...dia.com>
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, sd@...asysnail.net, netdev@...r.kernel.org,
        leon@...nel.org
Subject: Re: [PATCH net-next v3 2/4] net/mlx5: Support MACsec over VLAN

On Thu, Mar 30, 2023 at 04:57:13PM +0300, Emeel Hakim wrote:
> MACsec device may have a VLAN device on top of it.
> Detect MACsec state correctly under this condition,
> and return the correct net device accordingly.
> 
> Signed-off-by: Emeel Hakim <ehakim@...dia.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>

...

> @@ -510,7 +520,7 @@ static int mlx5e_macsec_add_txsa(struct macsec_context *ctx)
>  {
>  	const struct macsec_tx_sc *tx_sc = &ctx->secy->tx_sc;
>  	const struct macsec_tx_sa *ctx_tx_sa = ctx->sa.tx_sa;
> -	struct mlx5e_priv *priv = netdev_priv(ctx->netdev);
> +	struct mlx5e_priv *priv = macsec_netdev_priv(ctx->netdev);

nit: If you need to respin for some other reason you may wish
     to consider reverse xmas tree - longest line to shortest -
     for local variable declarations

>  	const struct macsec_secy *secy = ctx->secy;
>  	struct mlx5e_macsec_device *macsec_device;
>  	struct mlx5_core_dev *mdev = priv->mdev;
> @@ -585,7 +595,7 @@ static int mlx5e_macsec_upd_txsa(struct macsec_context *ctx)
>  {
>  	const struct macsec_tx_sc *tx_sc = &ctx->secy->tx_sc;
>  	const struct macsec_tx_sa *ctx_tx_sa = ctx->sa.tx_sa;
> -	struct mlx5e_priv *priv = netdev_priv(ctx->netdev);
> +	struct mlx5e_priv *priv = macsec_netdev_priv(ctx->netdev);

ditto.

>  	struct mlx5e_macsec_device *macsec_device;
>  	u8 assoc_num = ctx->sa.assoc_num;
>  	struct mlx5e_macsec_sa *tx_sa;