netdev - Re: [PATCH net-next v3 3/4] net/mlx5: Consider VLAN interface in MACsec TX steering rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCbk+2oblodtwSQc@corigine.com>
Date:   Fri, 31 Mar 2023 15:49:47 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Emeel Hakim <ehakim@...dia.com>
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, sd@...asysnail.net, netdev@...r.kernel.org,
        leon@...nel.org
Subject: Re: [PATCH net-next v3 3/4] net/mlx5: Consider VLAN interface in
 MACsec TX steering rules

On Thu, Mar 30, 2023 at 04:57:14PM +0300, Emeel Hakim wrote:
> Offloading MACsec when its configured over VLAN with current MACsec
> TX steering rules will wrongly insert MACsec sec tag after inserting
> the VLAN header leading to a ETHERNET | SECTAG | VLAN packet when
> ETHERNET | VLAN | SECTAG is configured.
> 
> The above issue is due to adding the SECTAG by HW which is a later
> stage compared to the VLAN header insertion stage.
> 
> Detect such a case and adjust TX steering rules to insert the
> SECTAG in the correct place by using reformat_param_0 field in
> the packet reformat to indicate the offset of SECTAG from end of
> the MAC header to account for VLANs in granularity of 4Bytes.
> 
> Signed-off-by: Emeel Hakim <ehakim@...dia.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>