[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <168027415284.32751.5288169344605905589.kvalo@kernel.org>
Date: Fri, 31 Mar 2023 14:49:14 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Cai Huoqing <cai.huoqing@...ux.dev>
Cc: cai.huoqing@...ux.dev, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Yan-Hsuan Chuang <tony0620emma@...il.com>,
Ping-Ke Shih <pkshih@...ltek.com>, ath10k@...ts.infradead.org,
linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, ath11k@...ts.infradead.org,
ath12k@...ts.infradead.org
Subject: Re: [PATCH 4/5] wifi: rtw88: Remove redundant pci_clear_master
Cai Huoqing <cai.huoqing@...ux.dev> wrote:
> Remove pci_clear_master to simplify the code,
> the bus-mastering is also cleared in do_pci_disable_device,
> like this:
> ./drivers/pci/pci.c:2197
> static void do_pci_disable_device(struct pci_dev *dev)
> {
> u16 pci_command;
>
> pci_read_config_word(dev, PCI_COMMAND, &pci_command);
> if (pci_command & PCI_COMMAND_MASTER) {
> pci_command &= ~PCI_COMMAND_MASTER;
> pci_write_config_word(dev, PCI_COMMAND, pci_command);
> }
>
> pcibios_disable_device(dev);
> }.
> And dev->is_busmaster is set to 0 in pci_disable_device.
>
> Signed-off-by: Cai Huoqing <cai.huoqing@...ux.dev>
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> Reviewed-by: Ping-Ke Shih <pkshih@...ltek.com>
Patch applied to wireless-next.git, thanks.
e665c6d67e54 wifi: rtw88: Remove redundant pci_clear_master
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230323112613.7550-4-cai.huoqing@linux.dev/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists