netdev - Is udp-gro supposed to work on all network cards?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 31 Mar 2023 13:39:48 -0700
From:   Ben Greear <greearb@...delatech.com>
To:     netdev@...r.kernel.org
Subject: Is udp-gro supposed to work on all network cards?

Hello,

I recently started working with udp-gro (sendmmsg extension).  It seems to work great when
sending to/from intel ax210 wifi station, but when I try on mtk7922 radio, I get -EIO from
the sendmmsg call and the data packets are not seen on the network device if I sniff.

Looks like most offloads are not enabled on this netdev.  Should I still expect udp-gro
sends to work (like with software fallback somewhere in the stack), or must I just not
use that feature on network cards not supporting it?

[root@...23c-3b7f ~]# ethtool -k wlan20|grep ": on"
rx-checksumming: on [fixed]
generic-receive-offload: on
netns-local: on [fixed]

[root@...23c-3b7f ~]# ethtool -k wlan20|grep udp
tx-udp_tnl-segmentation: off [fixed]
tx-udp_tnl-csum-segmentation: off [fixed]
tx-udp-segmentation: off [fixed]
rx-udp_tunnel-port-offload: off [fixed]
rx-udp-gro-forwarding: off

Thanks,
Ben

-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com