netdev - Re: [PATCH v3 2/2] net: stmmac: dwmac-imx: use platform specific reset for imx93 SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 31 Mar 2023 18:07:38 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Shenwei Wang <shenwei.wang@....com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        Wong Vee Khee <veekhee@...le.com>,
        Tan Tee Min <tee.min.tan@...ux.intel.com>,
        Revanth Kumar Uppala <ruppala@...dia.com>,
        Jon Hunter <jonathanh@...dia.com>,
        Andrey Konovalov <andrey.konovalov@...aro.org>,
        netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, imx@...ts.linux.dev
Subject: Re: [PATCH v3 2/2] net: stmmac: dwmac-imx: use platform specific
 reset for imx93 SoCs

Hi Shenwei,

On Fri, Mar 31, 2023 at 5:58 PM Shenwei Wang <shenwei.wang@....com> wrote:
>
> The patch addresses an issue with the reset logic on the i.MX93 SoC, which
> requires configuration of the correct interface speed under RMII mode to
> complete the reset. The patch implements a fix_soc_reset function and uses
> it specifically for the i.MX93 SoCs.
>
> Signed-off-by: Shenwei Wang <shenwei.wang@....com>
> ---
>  .../net/ethernet/stmicro/stmmac/dwmac-imx.c   | 29 ++++++++++++++++++-
>  1 file changed, 28 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
> index ac8580f501e2..3dfd13840535 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
> @@ -19,9 +19,9 @@
>  #include <linux/pm_wakeirq.h>
>  #include <linux/regmap.h>
>  #include <linux/slab.h>
> -#include <linux/stmmac.h>
>
>  #include "stmmac_platform.h"
> +#include "common.h"

These changes in the header seem to be unrelated.

Apart from that:

Reviewed-by: Fabio Estevam <festevam@...il.com>