netdev - Re: [PATCH] net: wwan: t7xx: do not compile with -Werror

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b26331de-da68-afd2-b895-14dd219902e3@kernel.org>
Date:   Fri, 31 Mar 2023 08:36:06 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     kuba@...nel.org
Cc:     linux-kernel@...r.kernel.org,
        Chandrashekar Devegowda <chandrashekar.devegowda@...el.com>,
        Intel Corporation <linuxwwan@...el.com>,
        Chiranjeevi Rapolu <chiranjeevi.rapolu@...ux.intel.com>,
        Liu Haijun <haijun.liu@...iatek.com>,
        M Chetan Kumar <m.chetan.kumar@...ux.intel.com>,
        Ricardo Martinez <ricardo.martinez@...ux.intel.com>,
        Loic Poulain <loic.poulain@...aro.org>,
        Sergey Ryazanov <ryazanov.s.a@...il.com>,
        Johannes Berg <johannes@...solutions.net>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: wwan: t7xx: do not compile with -Werror

It should have been [PATCH v2] in the subject. Do you want me to resend?

On 31. 03. 23, 8:35, Jiri Slaby (SUSE) wrote:
> When playing with various compilers or their versions, some choke on
> the t7xx code. For example (with gcc 13):
>   In file included from ./arch/s390/include/generated/asm/rwonce.h:1,
>                    from ../include/linux/compiler.h:247,
>                    from ../include/linux/build_bug.h:5,
>                    from ../include/linux/bits.h:22,
>                    from ../drivers/net/wwan/t7xx/t7xx_state_monitor.c:17:
>   In function 'preempt_count',
>       inlined from 't7xx_fsm_append_event' at ../drivers/net/wwan/t7xx/t7xx_state_monitor.c:439:43:
>   ../include/asm-generic/rwonce.h:44:26: error: array subscript 0 is outside array bounds of 'const volatile int[0]' [-Werror=array-bounds=]
> 
> There is no reason for any code in the kernel to be built with -Werror
> by default. Note that we have generic CONFIG_WERROR. So if anyone wants
> -Werror, they can enable that.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> Link: https://lore.kernel.org/all/20230330232717.1f8bf5ea@kernel.org/
> Cc: Chandrashekar Devegowda <chandrashekar.devegowda@...el.com>
> Cc: Intel Corporation <linuxwwan@...el.com>
> Cc: Chiranjeevi Rapolu <chiranjeevi.rapolu@...ux.intel.com>
> Cc: Liu Haijun <haijun.liu@...iatek.com>
> Cc: M Chetan Kumar <m.chetan.kumar@...ux.intel.com>
> Cc: Ricardo Martinez <ricardo.martinez@...ux.intel.com>
> Cc: Loic Poulain <loic.poulain@...aro.org>
> Cc: Sergey Ryazanov <ryazanov.s.a@...il.com>
> Cc: Johannes Berg <johannes@...solutions.net>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: netdev@...r.kernel.org
> ---
> 
> Notes:
>      [v2] delete the line completely
> 
>   drivers/net/wwan/t7xx/Makefile | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/wwan/t7xx/Makefile b/drivers/net/wwan/t7xx/Makefile
> index 268ff9e87e5b..2652cd00504e 100644
> --- a/drivers/net/wwan/t7xx/Makefile
> +++ b/drivers/net/wwan/t7xx/Makefile
> @@ -1,7 +1,5 @@
>   # SPDX-License-Identifier: GPL-2.0-only
>   
> -ccflags-y += -Werror
> -
>   obj-${CONFIG_MTK_T7XX} := mtk_t7xx.o
>   mtk_t7xx-y:=	t7xx_pci.o \
>   		t7xx_pcie_mac.o \

-- 
js