netdev - Re: [PATCH net] gve: Secure enough bytes in the first TX desc for all TCP pkts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230331212924.49bc1c64@kernel.org>
Date:   Fri, 31 Mar 2023 21:29:24 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Shailend Chand <shailend@...gle.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net] gve: Secure enough bytes in the first TX desc for
 all TCP pkts

On Thu, 30 Mar 2023 15:09:39 -0700 Shailend Chand wrote:
> +	/* If the skb is gso, then we want the tcp header alone in the first segment
> +	 * otherwise we want the spec-stipulated minimum of 182B.
>  	 */
>  	hlen = is_gso ? l4_hdr_offset + tcp_hdrlen(skb) :
> -			skb_headlen(skb);
> +			min_t(int, 182, skb->len);

What spec are we talking about here?
Please add a define for the magic number.