netdev - Re: [PATCH net-next 3/3] bnxt: use new queue try_stop/try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLimbua7=oRxvVKbNMnm71462GBtOs3L4w7HBUDdChSohSg@mail.gmail.com>
Date:   Sat, 1 Apr 2023 11:35:03 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com
Subject: Re: [PATCH net-next 3/3] bnxt: use new queue try_stop/try_wake macros

On Fri, Mar 31, 2023 at 10:12 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Convert bnxt to use new macros rather than open code the logic.
> Two differences:
> (1) bnxt_tx_int() will now only issue a memory barrier if it sees
>     enough space on the ring to wake the queue. This should be fine,
>     the mb() is between the writes to the ring pointers and checking
>     queue state.
> (2) we'll start the queue instead of waking on race, this should
>     be safe inside the xmit handler.
>

Reviewed that these 2 differences should be fine.  Thanks.

Reviewed-by: Michael Chan <michael.chan@...adcom.com>

> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: michael.chan@...adcom.com
> ---

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)