netdev - Re: [PATCH net-next 0/7] net: phy: smsc: add support for edpd tunable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFXsbZpdLbcpZzO-4FSdaMo1CNn4yYZ9=Pa-UBu+zOVn7DFpiA@mail.gmail.com>
Date:   Sun, 2 Apr 2023 16:33:18 -0700
From:   Chris Healy <cphealy@...il.com>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/7] net: phy: smsc: add support for edpd tunable

On Sun, Apr 2, 2023 at 7:58 AM Heiner Kallweit <hkallweit1@...il.com> wrote:
>
> On 02.04.2023 16:00, Florian Fainelli wrote:
> >
> >
> > On 4/2/2023 2:43 AM, Heiner Kallweit wrote:
> >> This adds support for the EDPD PHY tunable.
> >> Per default EDPD is disabled in interrupt mode, the tunable can be used
> >> to override this, e.g. if the link partner doesn't use EDPD.
> >> The interval to check for energy can be chosen between 1000ms and
> >> 2000ms. Note that this value consists of the 1000ms phylib interval
> >> for state machine runs plus the time to wait for energy being detected.
> >
> > AFAIR Chris Healy was trying to get something similar done, maybe you can CC him on the next version?
>
> Actually this is based on a conversation between him and me. Chris came up
> with a first version and I reworked it from scratch to meet mainline standards
> and make it usable on SMSC and Amlogic PHY's.
>

It's great to see this feature coming together.  I wish I would have
had more time to help out.