netdev - Re: [PATCH net-next 5/7] net: add struct kernel_hwtstamp_config and make net_hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <531f7c0b-e453-5b5e-6230-5915b12e8a19@gmail.com>
Date:   Sun, 2 Apr 2023 05:57:06 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>,
        Maxim Georgiev <glipus@...il.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Köry Maincent <kory.maincent@...tlin.com>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next 5/7] net: add struct kernel_hwtstamp_config and
 make net_hwtstamp_validate() use it



On 4/2/2023 5:37 AM, Vladimir Oltean wrote:
> Jakub Kicinski suggested that we may want to add new UAPI for
> controlling hardware timestamping through netlink in the future, and in
> that case, we will be limited to the struct hwtstamp_config that is
> currently passed in fixed binary format through the SIOCGHWTSTAMP and
> SIOCSHWTSTAMP ioctls. It would be good if new kernel code already
> started operating on an extensible kernel variant of that structure,
> similar in concept to struct kernel_ethtool_coalesce vs struct
> ethtool_coalesce.
> 
> Since struct hwtstamp_config is in include/uapi/linux/net_tstamp.h, here
> we introduce include/linux/net_tstamp.h which shadows that other header,
> but also includes it, so that existing includers of this header work as
> before. In addition to that, we add the definition for the kernel-only
> structure, and a helper which translates all fields by manual copying.
> I am doing a manual copy in order to not force the alignment (or type)
> of the fields of struct kernel_hwtstamp_config to be the same as of
> struct hwtstamp_config, even though now, they are the same.
> 
> Link: https://lore.kernel.org/netdev/20230330223519.36ce7d23@kernel.org/
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian