netdev - Re: [PATCH net-next 3/7] net: promote SIOCSHWTSTAMP and SIOCGHWTSTAMP ioctls to dedicated handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230402130159.xwacksnmymmthxtm@skbuf>
Date:   Sun, 2 Apr 2023 16:01:59 +0300
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>,
        Maxim Georgiev <glipus@...il.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Köry Maincent <kory.maincent@...tlin.com>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next 3/7] net: promote SIOCSHWTSTAMP and
 SIOCGHWTSTAMP ioctls to dedicated handlers

On Sun, Apr 02, 2023 at 05:56:33AM -0700, Florian Fainelli wrote:
> 
> 
> On 4/2/2023 5:53 AM, Vladimir Oltean wrote:
> > On Sun, Apr 02, 2023 at 05:52:29AM -0700, Florian Fainelli wrote:
> > > PS: there could be some interesting use cases with SIO(S|G)MII(REG|PHY) to
> > > be explored, but not for now.
> > 
> > You mean with DSA intercepting them on the master? Details?
> 
> Humm, maybe this is an -ENOTENOUGHCOFFEE situation, if we have a fixed-link,
> we would not do anything of value. If we have a PHY-less configuration same
> thing. So it would only be a sort of configuration where the switch side has
> a PHY and the MAC connects to it that would be of any value.

But the last case could be handled directly through a phy_mii_ioctl()
issued by the DSA master's own ndo_eth_ioctl() handler, no need for DSA
to intervene, right?