netdev - Re: [PATCH iproute2-next 0/9] Add tc-mqprio and tc-taprio support for preemptible traffic classes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6546e93dca588c3c01e56466e6f5ae10e37870bf.camel@gmail.com>
Date:   Mon, 03 Apr 2023 13:18:07 +0200
From:   Ferenc Fejes <primalgamer@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     David Ahern <dsahern@...nel.org>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Péter Antal <antal.peti99@...il.com>
Subject: Re: [PATCH iproute2-next 0/9] Add tc-mqprio and tc-taprio support
 for preemptible traffic classes

Hi Vladimir!

On Mon, 2023-04-03 at 13:52 +0300, Vladimir Oltean wrote:
> This is the iproute2 support for the tc program to make use of the
> kernel feature for preemptible traffic classes described here:
> https://patchwork.kernel.org/project/netdevbpf/cover/20230403103440.2895683-1-vladimir.oltean@nxp.com/
> 
> The state of the man pages prior to this work was a bit
> unsatisfactory,
> so patches 03-07 contain some man page cleanup in tc-taprio(8) and
> tc-mqprio(8).
> 
> Vladimir Oltean (9):
>   uapi: add definitions for preemptible traffic classes in mqprio and
>     taprio
>   utils: add max() definition
>   tc/taprio: add max-sdu to the man page SYNOPSIS section
>   tc/taprio: add a size table to the examples from the man page

Seems like Stephen merged Péter's manpages patch [1] but IMO your
version [2] is a better overhaul of that, also Péter ACK-ed to go
forward with that version. Looks like you rebased this work on the new
manpages, you have any plan to submit the changes from [2] separately?
Probably Stephen missed the whole discussion and about [2] and I'm
admit that putting acked/reviewed into a mail inside the discussion
might be misleading (probably thats show up for the original patch in
patchwork). Sorry for making it complicated.

>   tc/mqprio: fix stray ] in man page synopsis
>   tc/mqprio: use words in man page to express min_rate/max_rate
>     dependency on bw_rlimit
>   tc/mqprio: break up synopsis into multiple lines
>   tc/mqprio: add support for preemptible traffic classes
>   tc/taprio: add support for preemptible traffic classes
> 
>  include/uapi/linux/pkt_sched.h | 17 ++++++
>  include/utils.h                |  8 +++
>  man/man8/tc-mqprio.8           | 92 ++++++++++++++++++++++---------
>  man/man8/tc-taprio.8           | 27 ++++++++--
>  tc/q_mqprio.c                  | 98
> +++++++++++++++++++++++++++++++++
>  tc/q_taprio.c                  | 99 +++++++++++++++++++++++++-------
> --
>  6 files changed, 289 insertions(+), 52 deletions(-)
> 

[1]
https://lore.kernel.org/netdev/167789641838.26474.2747633103367439718.git-patchwork-notify@kernel.org/

[2]
https://lore.kernel.org/netdev/20230220161809.t2vj6daixio7uzbw@skbuf/

Best,
Ferenc