netdev - Re: [PATCH net-next 6/6] net: txgbe: Support phylink MAC layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca3c82a9-4160-422a-a618-04ab04a19015@lunn.ch>
Date:   Mon, 3 Apr 2023 15:22:03 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jiawen Wu <jiawenwu@...stnetic.com>
Cc:     netdev@...r.kernel.org, linux@...linux.org.uk,
        mengyuanlou@...-swift.com
Subject: Re: [PATCH net-next 6/6] net: txgbe: Support phylink MAC layer

> @@ -215,23 +216,15 @@ static void txgbe_up_complete(struct wx *wx)
>  	smp_mb__before_atomic();
>  	wx_napi_enable_all(wx);
>  
> +	phylink_start(txgbe->phylink);
> +

>  static void txgbe_down(struct wx *wx)
>  {
> +	struct txgbe *txgbe = (struct txgbe *)wx->priv;
> +
>  	txgbe_disable_device(wx);
>  	txgbe_reset(wx);
> +	if (txgbe->phylink)
> +		phylink_stop(txgbe->phylink);

You uncoditionally phylink_start(). Does this need to be conditional?

> +static void txgbe_mac_config(struct phylink_config *config, unsigned int mode,
> +			     const struct phylink_link_state *state)
> +{
> +}

That is very likely to be wrong. Lets see what Russell says.

     Andrew