netdev - RE: [EXT] Re: [PATCH v4 1/2] net: stmmac: add support for platform specific reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PAXPR04MB9185855577B999D41B3C9DC789929@PAXPR04MB9185.eurprd04.prod.outlook.com>
Date:   Mon, 3 Apr 2023 13:53:34 +0000
From:   Shenwei Wang <shenwei.wang@....com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        Wong Vee Khee <veekhee@...le.com>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Revanth Kumar Uppala <ruppala@...dia.com>,
        Andrey Konovalov <andrey.konovalov@...aro.org>,
        Tan Tee Min <tee.min.tan@...ux.intel.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [EXT] Re: [PATCH v4 1/2] net: stmmac: add support for platform
 specific reset



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Friday, March 31, 2023 11:58 PM
> To: Shenwei Wang <shenwei.wang@....com>
> Cc: David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Paolo Abeni <pabeni@...hat.com>; Shawn Guo
> <shawnguo@...nel.org>; Sascha Hauer <s.hauer@...gutronix.de>; Maxime
> Coquelin <mcoquelin.stm32@...il.com>; Giuseppe Cavallaro
> <peppe.cavallaro@...com>; Alexandre Torgue <alexandre.torgue@...s.st.com>;
> Jose Abreu <joabreu@...opsys.com>; Pengutronix Kernel Team
> <kernel@...gutronix.de>; Fabio Estevam <festevam@...il.com>; dl-linux-imx
> <linux-imx@....com>; Wong Vee Khee <veekhee@...le.com>; Kurt
> Kanzenbach <kurt@...utronix.de>; Revanth Kumar Uppala
> <ruppala@...dia.com>; Andrey Konovalov <andrey.konovalov@...aro.org>; Tan
> Tee Min <tee.min.tan@...ux.intel.com>; netdev@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-stm32@...md-mailman.stormreply.com;
> imx@...ts.linux.dev
> Subject: [EXT] Re: [PATCH v4 1/2] net: stmmac: add support for platform specific
> reset
> 
> Caution: EXT Email
> 
> On Fri, 31 Mar 2023 16:22:49 -0500 Shenwei Wang wrote:
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.h
> > b/drivers/net/ethernet/stmicro/stmmac/hwif.h
> > index 16a7421715cb..47a68f506c10 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/hwif.h
> > +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.h
> > @@ -214,8 +214,6 @@ struct stmmac_dma_ops {
> >       int (*enable_tbs)(void __iomem *ioaddr, bool en, u32 chan);  };
> >
> > -#define stmmac_reset(__priv, __args...) \
> > -     stmmac_do_callback(__priv, dma, reset, __args)
> >  #define stmmac_dma_init(__priv, __args...) \
> >       stmmac_do_void_callback(__priv, dma, init, __args)  #define
> > stmmac_init_chan(__priv, __args...) \ @@ -640,6 +638,7 @@ extern const
> > struct stmmac_mmc_ops dwxgmac_mmc_ops;
> >  #define GMAC_VERSION         0x00000020      /* GMAC CORE Version */
> >  #define GMAC4_VERSION                0x00000110      /* GMAC4+ CORE Version
> */
> >
> > +int stmmac_reset(struct stmmac_priv *priv, void *ioaddr);
> 
> sparse reports missing annotation, I think it's this line.
> It should have a __iomem tag. Try building with C=1 Also please take a look at:

Tried to rebuild with C=1 but didn't reproduce the missing annotation issue. However, the __iomem
should be added here.

Thanks,
Shenwei

> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ker
> nel.org%2Fdoc%2Fhtml%2Fnext%2Fprocess%2Fmaintainer-
> netdev.html&data=05%7C01%7Cshenwei.wang%40nxp.com%7Cb0c66303819f4
> c5c2eec08db326db89d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7
> C638159219052564995%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM
> DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C
> &sdata=0j58wSNzzTirX%2FqaJKPxYEDZn6ezs7qC39trHa72YRA%3D&reserved=0
> 
> >  int stmmac_hwif_init(struct stmmac_priv *priv);
>