netdev - Re: [PATCH net-next v2 1/2] net: flower: add support for matching cfm fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZCr2CNNhfwLrlg3j@corigine.com>
Date:   Mon, 3 Apr 2023 17:51:36 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Zahari Doychev <zahari.doychev@...ux.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, hmehrtens@...linear.com,
        aleksander.lobakin@...el.com,
        Zahari Doychev <zdoychev@...linear.com>
Subject: Re: [PATCH net-next v2 1/2] net: flower: add support for matching
 cfm fields

On Mon, Apr 03, 2023 at 05:36:22PM +0200, Zahari Doychev wrote:
> On Mon, Apr 03, 2023 at 04:54:12PM +0200, Simon Horman wrote:
> > On Sun, Apr 02, 2023 at 05:10:30PM +0200, Zahari Doychev wrote:
> > > From: Zahari Doychev <zdoychev@...linear.com>

...

> > > @@ -1390,6 +1413,12 @@ bool __skb_flow_dissect(const struct net *net,
> > >  		break;
> > >  	}
> > >  
> > > +	case htons(ETH_P_CFM): {
> > > +		fdret = __skb_flow_dissect_cfm(skb, flow_dissector,
> > > +					       target_container, data,
> > > +					       nhoff, hlen);
> > 
> > I do like that you moved the handling into it's own function.
> > But I do also note that this style differs from adjacent code in this
> > file.
> 
> I would prefer to have an own function here as I find __skb_flow_dissect
> long enough already. But if you insist I am okay to change it.

I don't insist.
I like it the way it is.