netdev - Re: [PATCH net-next 7/7] net: create a netdev notifier for DSA to reject PTP on DSA master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230403164806.23ui4ghljau2xhqx@skbuf>
Date:   Mon, 3 Apr 2023 19:48:06 +0300
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Maxim Georgiev <glipus@...il.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Köry Maincent <kory.maincent@...tlin.com>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next 7/7] net: create a netdev notifier for DSA to
 reject PTP on DSA master

On Mon, Apr 03, 2023 at 08:30:19AM -0700, Jakub Kicinski wrote:
> On Sun,  2 Apr 2023 15:37:55 +0300 Vladimir Oltean wrote:
> > The established way for unrelated modules to react on a net device event
> > is via netdevice notifiers. So we create a new notifier which gets
> > called whenever there is an attempt to change hardware timestamping
> > settings on a device.
> 
> Two core parts of the kernel are not "unrelated modules".
> Notifiers make the code harder to maintain and reason about.
> 
> But what do I know, clearly the code is amazing since it 
> has been applied in <22h on a weekend :|

Responded privately.