netdev - Re: [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFXsbZq=uzfFjkYw3eWuTjvcGpn6TSoc_OJYCwgthr5jU9qBpQ@mail.gmail.com>
Date:   Mon, 3 Apr 2023 13:24:24 -0700
From:   Chris Healy <cphealy@...il.com>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Andrew Lunn <andrew@...n.ch>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "open list:ARM/Amlogic Meson..." <linux-amlogic@...ts.infradead.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support
 for G12A internal PHY

On Mon, Apr 3, 2023 at 12:35 PM Heiner Kallweit <hkallweit1@...il.com> wrote:
>
> Enable EDPD PHY tunable support for the G12A internal PHY, reusing the
> recently added tunable support in the smsc driver.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>  drivers/net/phy/meson-gxl.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
> index 3dea7c752..bb9b33b6b 100644
> --- a/drivers/net/phy/meson-gxl.c
> +++ b/drivers/net/phy/meson-gxl.c
> @@ -210,6 +210,10 @@ static struct phy_driver meson_gxl_phy[] = {
>                 .read_status    = lan87xx_read_status,
>                 .config_intr    = smsc_phy_config_intr,
>                 .handle_interrupt = smsc_phy_handle_interrupt,
> +
> +               .get_tunable    = smsc_phy_get_tunable,
> +               .set_tunable    = smsc_phy_set_tunable,
> +
>                 .suspend        = genphy_suspend,
Why add the empty lines before and after the two new lines?

>                 .resume         = genphy_resume,
>                 .read_mmd       = genphy_read_mmd_unsupported,
> --
> 2.40.0
>