netdev - Re: [PATCH net-next RFC v2] Add NDOs for hardware timestamp get/set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230403141918.3257a195@kernel.org>
Date:   Mon, 3 Apr 2023 14:19:18 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     Maxim Georgiev <glipus@...il.com>, kory.maincent@...tlin.com,
        netdev@...r.kernel.org, maxime.chevallier@...tlin.com
Subject: Re: [PATCH net-next RFC v2] Add NDOs for hardware timestamp get/set

On Mon, 3 Apr 2023 15:26:22 +0300 Vladimir Oltean wrote:
> > @@ -7365,6 +7364,8 @@ static const struct net_device_ops e1000e_netdev_ops = {
> >  	.ndo_set_features = e1000_set_features,
> >  	.ndo_fix_features = e1000_fix_features,
> >  	.ndo_features_check	= passthru_features_check,
> > +	.ndo_hwtstamp_get	= e1000e_hwtstamp_get,
> > +	.ndo_hwtstamp_set	= e1000e_hwtstamp_set,
> >  };  
> 
> The conversion per se looks almost in line with what I was expecting to
> see, except for the comments. I guess you can convert a single driver
> first (e1000 seems fine), to get the API merged, then more people could
> work in parallel?
> 
> Or do you want netdevsim to cover hardware timestamping from the
> beginning too, Jakub?

I'd vote to split netdevsim out, and it needs a selftest which
exercises it under tools/testing/selftests/drivers/net/netdevsim/
to get merged...